Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension stuck on updating after resuming from hibernation #44

Open
mcat95 opened this issue Sep 24, 2017 · 2 comments
Open

Extension stuck on updating after resuming from hibernation #44

mcat95 opened this issue Sep 24, 2017 · 2 comments

Comments

@mcat95
Copy link
Contributor

mcat95 commented Sep 24, 2017

When I resume my computer from hibernation, the extension doesn't show any streamers, and it shows 'updating...' instead of the update button. I need to restart gnome-shell (Alt+F2 -> r) for it to work again.

Why can this be happening?

@maweki
Copy link
Owner

maweki commented Sep 25, 2017

Looking at the code this always happens but should resolve itself after the auto update cycle.

When we start the update we disable the button (https://github.com/maweki/twitchlive-extension/blob/master/extension.js#L174-L175). We re-enable it once it is done (https://github.com/maweki/twitchlive-extension/blob/master/extension.js#L221-L223). If there is a failure, we don't re-enable the update button (https://github.com/maweki/twitchlive-extension/blob/master/extension.js#L228-L231). Then there's no manual way to update but the auto-update should resolve this.

I think there is an easy fix. Maybe we reactivate the button and let it say "Update Error" or something like this.

@mcat95 Maybe you want to try for a fix :)

@mcat95
Copy link
Contributor Author

mcat95 commented Sep 25, 2017

This is just speculation, but maybe the problem is with the timer not rescheduling correctly. As you said, it should work but I suspect this has something to do with the issue. It says:
It may or may not continue to tick during times where the machine is suspended.

I don't know how GLib handles this, according to this blog post of 2007, it should at least call the function when the system resumes.

I will try to get a more consistent way of reproducing the error and then we'll think about the fix 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants