Also, regarding tests, I don't fully understand how they work, do i have to add my new fixtures to roundtrip_test.go?scripts/ci.sh runs go generate on the fixtures and then checks if the generated files changed with git diff, so it will detect any breakage.

Also, regarding tests, I don't fully understand how they work, do i have to add my new fixtures to roundtrip_test.go? scripts/ci.sh runs go generate on the fixtures and then checks if the generated files changed with git diff, so it will detect any breakage.

roundtrip_test.go contains integration tests that can be used to evaluate the output for a given test case, or assert on the file contents. This mostly helps during development but can also be used to prevent regressions.

One question is how to allow generating into a "$GOPACKAGE_test" package in the same directory. I previously implemented this in my fork and simply added a package name argument, however, the problem with that is that when you're generating into a different directory, being able to explicitly specify the package name instead of counterfeiter deriving it from the directory name is not incredibly useful, and when generating into the same package, it has to be "$GOPACKAGE_test", so there's only one valid value you can specify for the argument. Alternatively, there could a boolean argument that makes it "$GOPACKAGE_test" if generating into the same directory, but that argument wouldn't be useful when generating into a different directory.

I tend to agree that a boolean flag seems like the best solution for indicating that you want the fake to be generated into $GOPACKAGE_test.

is this getting merged?