Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate doesn't import packages referenced in type args #260

Open
Ralph7C2 opened this issue Oct 5, 2023 · 0 comments
Open

Generate doesn't import packages referenced in type args #260

Ralph7C2 opened this issue Oct 5, 2023 · 0 comments

Comments

@Ralph7C2
Copy link
Contributor

Ralph7C2 commented Oct 5, 2023

If an interface method or function uses a generic type with a specified type parameter, like:

type SomeInterface interface {
    Do(o Optional[pkg.SomeType])
}

The generated file will use Optional[pkg.SomeType], but not import pkg.

While there is a lot more work to fully support generic interfaces, this would improve interfaces that handle other generic types.

I've created a PR that fixes this: #258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ralph7C2