From d8e33198818b53ea218885eae606197a11ad60db Mon Sep 17 00:00:00 2001 From: Roel van Dijk Date: Thu, 6 Sep 2012 12:08:36 +0200 Subject: [PATCH 1/2] Fix bug with finding nodes in index with spaces in value. --- lib/neography/rest.rb | 2 +- spec/integration/rest_index_spec.rb | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/neography/rest.rb b/lib/neography/rest.rb index 03c0fd2..67fd182 100644 --- a/lib/neography/rest.rb +++ b/lib/neography/rest.rb @@ -314,7 +314,7 @@ def find_node_auto_index(*args) def find_node_index(*args) case args.size - when 3 then index = get("/index/node/#{args[0]}/#{args[1]}?query=#{args[2]}") || Array.new + when 3 then index = get("/index/node/#{args[0]}/#{args[1]}/#{args[2]}") || Array.new when 2 then index = get("/index/node/#{args[0]}?query=#{args[1]}") || Array.new end return nil if index.empty? diff --git a/spec/integration/rest_index_spec.rb b/spec/integration/rest_index_spec.rb index 19377ae..20ffcf6 100644 --- a/spec/integration/rest_index_spec.rb +++ b/spec/integration/rest_index_spec.rb @@ -224,6 +224,17 @@ @neo.remove_node_from_index("test_node_index", key, value, new_node) end + it "can find a node index with spaces in the value" do + new_node = @neo.create_node + key = generate_text(6) + value = generate_text + ' ' + generate_text + @neo.add_node_to_index("test_node_index", key, value, new_node) + new_index = @neo.find_node_index("test_node_index", key, value) + new_index.should_not be_nil + new_index.first["self"].should == new_node["self"] + @neo.remove_node_from_index("test_node_index", key, value, new_node) + end + it "can get a relationship index" do new_node1 = @neo.create_node new_node2 = @neo.create_node From 6289b7aee199d4acee4e4e0b6e492f1383d872c2 Mon Sep 17 00:00:00 2001 From: Roel van Dijk Date: Thu, 6 Sep 2012 14:27:57 +0200 Subject: [PATCH 2/2] Fix bug with finding nodes in index with spaces and/or slashes in value. --- lib/neography/rest.rb | 2 +- spec/integration/rest_index_spec.rb | 13 ++++++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/neography/rest.rb b/lib/neography/rest.rb index 67fd182..5e1d0ab 100644 --- a/lib/neography/rest.rb +++ b/lib/neography/rest.rb @@ -314,7 +314,7 @@ def find_node_auto_index(*args) def find_node_index(*args) case args.size - when 3 then index = get("/index/node/#{args[0]}/#{args[1]}/#{args[2]}") || Array.new + when 3 then index = get("/index/node/#{args[0]}/#{args[1]}?query=\"#{args[2]}\"") || Array.new when 2 then index = get("/index/node/#{args[0]}?query=#{args[1]}") || Array.new end return nil if index.empty? diff --git a/spec/integration/rest_index_spec.rb b/spec/integration/rest_index_spec.rb index 20ffcf6..2688ddf 100644 --- a/spec/integration/rest_index_spec.rb +++ b/spec/integration/rest_index_spec.rb @@ -235,6 +235,17 @@ @neo.remove_node_from_index("test_node_index", key, value, new_node) end + it "can find a node index with slashes in the value" do + new_node = @neo.create_node + key = generate_text(6) + value = generate_text + '/' + generate_text + @neo.add_node_to_index("test_node_index", key, value, new_node) + new_index = @neo.find_node_index("test_node_index", key, value) + new_index.should_not be_nil + new_index.first["self"].should == new_node["self"] + @neo.remove_node_from_index("test_node_index", key, value, new_node) + end + it "can get a relationship index" do new_node1 = @neo.create_node new_node2 = @neo.create_node @@ -398,4 +409,4 @@ end -end \ No newline at end of file +end