-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Games don't add up #27
Comments
I keep getting errors. I think something bugged in the plugin. |
Yea sadly getting errors now as well.. error is as followed:
hopefully @maxisoft is still around and active, so he can hopefully fix and update whatever is going on. |
It is a parsing error. The error happens at one of these two lines:
|
Hello 👋, I'll try to discuss the issues in a two-part follow-up. ❓ About the original issueI think the original issue is something related to #3 (comment)
There are three possible scenarios:
So I'll leave this issue open for some time to ensure (according to the comments) that the plugin is working as intended: for instance, for today Field of Glory II Limited Free Promotional Package - Jun 2023 should be added to one's game library. If it's not the case, it's definitely an issue ❗ 🐛 About the recent errors
I believe those errors occur when reddit servers are showing 5xx internal errors which serve a html page instead of json payload hence the errors 😕. As I think it's another issue I'll open a new issue ticket to track that 📝. |
This commit refactors the ASFFreeGamesPlugin class to follow the Single Responsibility Principle, which states that each class should have one responsibility, one single purpose. The main changes are: - Extracted some methods from ASFFreeGamesPlugin to reduce its complexity and increase cohesion. - Moved some methods to other classes where they belong. - Used more idiomatic C# patterns and features, such as string interpolation, var keyword, using statements, null operators, LINQ, async/await, etc. - Added XML documentation comments for public types and members. - Added regular comments for private or complex code blocks. - Added more unit tests to cover the refactored code. This commit also fixes: - Closes #28: Error when retrieving game list JSON data from reddit - Resolves #27: Games don't add up
This commit adds error handling for reddit 5xx responses that return invalid JSON data, which caused the plugin to fail when retrieving game list from reddit. This fixes issue #28 and #27. This commit also refactors the ASFFreeGamesPlugin class to follow the Single Responsibility Principle, which states that each class should have one responsibility, one single purpose. The main changes are: - Extracted some methods from ASFFreeGamesPlugin to reduce its complexity and increase cohesion. - Moved some methods to other classes where they belong. - Used more idiomatic C# patterns and features, such as string interpolation, var keyword, using statements, null operators, LINQ, async/await, etc. - Added XML documentation comments for public types and members. - Added regular comments for private or complex code blocks. - Added more unit tests to cover the refactored code.
I did everything right, I entered the command freegames, the program replied that it received 6 free games but they were not added to steam, unless it's not supposed to be added to stea, can someone help me??
The text was updated successfully, but these errors were encountered: