Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility of plugin version 1.4.0 with ASF 5.4.12.5 #43

Closed
Rekandy opened this issue Nov 4, 2023 · 2 comments · Fixed by #44
Closed

Incompatibility of plugin version 1.4.0 with ASF 5.4.12.5 #43

Rekandy opened this issue Nov 4, 2023 · 2 comments · Fixed by #44
Assignees
Labels
bug Something isn't working

Comments

@Rekandy
Copy link

Rekandy commented Nov 4, 2023

Error Description
Problem with launching the latest version of the plugin

To Reproduce
Steps to reproduce the behavior:
1.Installing plugin version 1.4.0
2.Running ASF and getting an error that indicates that all other plugins are not working(of course, when you remove the plugin all starts to work fine).

Expected behavior
Running the programme with all plug-ins

Screenshots
ArchiSteamFarm_RLpx8lfgPN

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser chrome
  • Version 1.4.0
@maxisoft maxisoft self-assigned this Nov 7, 2023
@maxisoft maxisoft pinned this issue Nov 7, 2023
@maxisoft
Copy link
Owner

maxisoft commented Nov 7, 2023

Thank you for reporting this issue. 👍

About the error

I have acknowledged the issue and found out that it is related to the trimming of the ASF binary, which removes some methods that are not used by the main program.
One of these methods is the Lazy(T) constructor that takes a value parameter, which was used by the PluginContext class. This causes a System.MissingMethodException when the plugin start and tries to access it.

Solutions

  • I will create a new release soon with a fix that avoids using the trimmed method.
  • In the meantime, I have marked the 1.4.0 version as pre-release to prevent users from seeing it on the main GitHub page. I apologize for any inconvenience this may have caused.
  • I am also working on fixing the integration tests to prevent these kind of issues from happening again.

Thank you for your patience and understanding. Have a nice day! 😊

maxisoft added a commit that referenced this issue Nov 7, 2023
The Lazy<T> constructor that takes a value parameter is trimmed in the official ASF binary, which causes a System.MissingMethodException when the plugin tries to access it. This commit fixes this issue by using a static lambda expression that returns the default cancellation token instead.

This commit closes #43.
@maxisoft maxisoft reopened this Nov 7, 2023
@maxisoft
Copy link
Owner

maxisoft commented Nov 7, 2023

issue should be resolved with latest release https://github.com/maxisoft/ASFFreeGames/releases/tag/v1.4.1.

@maxisoft maxisoft closed this as completed Nov 7, 2023
@maxisoft maxisoft added the bug Something isn't working label Nov 7, 2023
@maxisoft maxisoft unpinned this issue Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants