Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Concern: Storing Proxy Passwords in Clear Text #86

Open
maxisoft opened this issue Aug 8, 2024 · 0 comments
Open

Security Concern: Storing Proxy Passwords in Clear Text #86

maxisoft opened this issue Aug 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@maxisoft
Copy link
Owner

maxisoft commented Aug 8, 2024

There's a potential security risk associated with the current proxy configuration mechanism. The plugin allows users to set proxy information either through environment variables or by editing the freegames.json.config file. However, if a proxy password is provided, it is stored in clear text within the JSON file, even when passed via the environment variable.

This behavior could lead to sensitive data exposure if the configuration file is shared or accidentally leaked.

I propose implementing a mechanism to exclude sensitive data, such as proxy passwords, from being saved to the configuration file. This could involve:

  • Removing the proxy password from the configuration file when it's provided via an environment variable.
  • Encrypting the proxy password before storing it in the configuration file.
  • Providing an alternative, more secure method for storing proxy credentials.

It's crucial to address this issue to protect user data and enhance the plugin's security.

@maxisoft maxisoft added the bug Something isn't working label Aug 8, 2024
@maxisoft maxisoft self-assigned this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant