Add new phone outputs #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oschwald
commented
Jun 25, 2024
oschwald
commented
- Add new phone outputs
- Add newlines to end of files
- Expect asserts in test
oschwald
force-pushed
the
greg/phone-data
branch
from
da5686d to
93ed7ae
Compare
ugexe
requested changes
Jun 27, 2024
src/MinFraud/Model/Insights.php
Outdated
| @@ -15,6 +15,12 @@ class Insights implements \JsonSerializable | |||
| */ | |||
| public readonly BillingAddress $billingAddress; | |||
|
|
|||
| /** | |||
| * @var Phone an object containing minFraud date related to the billing | |||
There was a problem hiding this comment.
Suggested change
| * @var Phone an object containing minFraud date related to the billing | |
| * @var Phone an object containing minFraud data related to the billing |
src/MinFraud/Model/Insights.php
Outdated
| @@ -81,6 +87,12 @@ class Insights implements \JsonSerializable | |||
| */ | |||
| public readonly ShippingAddress $shippingAddress; | |||
|
|
|||
| /** | |||
| * @var Phone an object containing minFraud date related to the shipping | |||
There was a problem hiding this comment.
Suggested change
| * @var Phone an object containing minFraud date related to the shipping | |
| * @var Phone an object containing minFraud data related to the shipping |
ugexe
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.