Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HSTS; HTTP endpoint should be immediately deprecated. #39

Open
sirocyl opened this issue Nov 14, 2017 · 0 comments
Open

Use HSTS; HTTP endpoint should be immediately deprecated. #39

sirocyl opened this issue Nov 14, 2017 · 0 comments

Comments

@sirocyl
Copy link

sirocyl commented Nov 14, 2017

This application carries a lot of risk for an MITM attack on a less-than-secure network environment, such as public WLAN. While it does have an HTTPS frontend, the fact that the HTTP one exists, and is the default, is troubling.

At this time, anyone could simply gain control of network packets between the client and the host, and substitute their own version of the OSP page, with one which may exfiltrate one's passwords or do other nefarious things.

HSTS is important for applications like this. It ensures that an HTTPS connection, and only a strongly-secure HTTPS connection, can be made by the browser.

This doesn't affect the open source code, as far as I can tell; this is a server configuration issue for the oneshallpass.com website/host.

This could be solved by hosting on Github Pages, since it uses HSTS; see #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant