Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andere foutmelding bij toewijzen medebeoordelaar #637

Closed
2 tasks done
svenvandescheur opened this issue Jan 23, 2025 · 1 comment · Fixed by #640 or #653
Closed
2 tasks done

Andere foutmelding bij toewijzen medebeoordelaar #637

svenvandescheur opened this issue Jan 23, 2025 · 1 comment · Fixed by #640 or #653
Assignees
@Xaohs
Labels
bug Something isn't working

Comments

@svenvandescheur
Copy link
Contributor

svenvandescheur commented Jan 23, 2025 •
edited by SilviaAmAm
Loading

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258?selectedIssue=PZ-5168

To reproduce:

Case 1:

  • Create a destruction list as user A and assign user B as a reviewer.
  • Submit the list for review
  • As user A, try to assign yourself as co-reviewer. The error says:

Image

Case 2:

  • Create a destruction list as user A and assign user B as a reviewer.
  • Submit the list for review
  • Log in as record manager C and try to assign user A as co-reviewer. The error says:

Image

To do

Backend

  • Return the right error message

Frontend

  • Filter out the author from the (co-)reviewer dropdown, so that it cannot be selected.
@svenvandescheur svenvandescheur converted this from a draft issue Jan 23, 2025
@svenvandescheur svenvandescheur added the bug Something isn't working label Jan 23, 2025
@SilviaAmAm SilviaAmAm moved this from Todo to In Progress in Open Archiefbeheer - Sprints Jan 23, 2025
SilviaAmAm added a commit that referenced this issue Jan 23, 2025
@SilviaAmAm
🐛 [#637] Record manager can reassign co-reviewers
d137a4b
SilviaAmAm added a commit that referenced this issue Jan 23, 2025
@SilviaAmAm
🌐 [#637] Update translations
d94986e
SilviaAmAm added a commit that referenced this issue Jan 23, 2025
@SilviaAmAm
✅ [#637] Update tests
7939079
@SilviaAmAm SilviaAmAm mentioned this issue Jan 23, 2025
Merged
@SilviaAmAm SilviaAmAm moved this from In Progress to Has Pull Request in Open Archiefbeheer - Sprints Jan 23, 2025
SilviaAmAm added a commit that referenced this issue Jan 24, 2025
@SilviaAmAm
🐛 [#637] Record manager can reassign co-reviewers
3837920
SilviaAmAm added a commit that referenced this issue Jan 24, 2025
@SilviaAmAm
🌐 [#637] Update translations
55944a1
SilviaAmAm added a commit that referenced this issue Jan 24, 2025
@SilviaAmAm
✅ [#637] Update tests
d5de54d
@SilviaAmAm SilviaAmAm moved this from Has Pull Request to In Progress in Open Archiefbeheer - Sprints Jan 24, 2025
SilviaAmAm added a commit that referenced this issue Jan 27, 2025
@SilviaAmAm
🐛 [#637] Record manager can reassign co-reviewers
fd32f13
SilviaAmAm added a commit that referenced this issue Jan 27, 2025
@SilviaAmAm
🌐 [#637] Update translations
1233fe0
SilviaAmAm added a commit that referenced this issue Jan 27, 2025
@SilviaAmAm
✅ [#637] Update tests
1f6bc39
@SilviaAmAm SilviaAmAm moved this from In Progress to Has Pull Request in Open Archiefbeheer - Sprints Jan 27, 2025
SilviaAmAm added a commit that referenced this issue Jan 27, 2025
@SilviaAmAm
Merge pull request #640 from maykinmedia/fix/637-record-manager-can-u…
6a82efc 
…pdate-coreviewers

[#637] Record manager can update coreviewers
@github-project-automation github-project-automation bot moved this from Has Pull Request to Done in Open Archiefbeheer - Sprints Jan 27, 2025
@SilviaAmAm SilviaAmAm moved this from Done to Todo in Open Archiefbeheer - Sprints Jan 27, 2025
@SilviaAmAm SilviaAmAm removed their assignment Jan 27, 2025
@SilviaAmAm
Copy link
Collaborator

Frontend still to do

@SilviaAmAm SilviaAmAm reopened this Jan 27, 2025
Xaohs pushed a commit that referenced this issue Jan 29, 2025
🐛 #637 - removed author from selection
9b4b999
@Xaohs Xaohs mentioned this issue Jan 29, 2025
Merged
svenvandescheur pushed a commit that referenced this issue Jan 30, 2025
@svenvandescheur
🐛 #637 - removed author from selection
14a27fb
@SilviaAmAm SilviaAmAm mentioned this issue Jan 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xaohs Xaohs

Labels
bug Something isn't working
Projects
Open Archiefbeheer - Sprints
Status: Done
Milestone
No milestone
3 participants
@svenvandescheur @SilviaAmAm @Xaohs