Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] search by custom pattern in "untranslated only" messages #177

Open
kichawa opened this issue Dec 22, 2016 · 1 comment
Open

[FEATURE] search by custom pattern in "untranslated only" messages #177

kichawa opened this issue Dec 22, 2016 · 1 comment

Comments

@kichawa
Copy link

kichawa commented Dec 22, 2016

  • Which version of Django are you using?:
    Django==1.9.3
  • Which version of django-rosetta are you using?:
    django-rosetta==0.7.11
  • Have you looked trough recent issues and checked this isn't a duplicate?
    yes

Is there any change to combine searching by custom pattern and filtering by for example 'untranslated only'?
I would like to fix it in the future.

https://github.com/mbi/django-rosetta/blob/develop/rosetta/views.py#L207-L219

@mbi
Copy link
Owner

mbi commented Dec 22, 2016

Sounds like a pretty good idea, I'd definitely accept a PR if it includes tests. I think what you'd need to do is evaluate a list of entries based on the filters, then filter that list further via the search term, and finally pass the result to the Paginator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants