-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ngposts obfuscation doesn't seem to work #177
Comments
knock knock... is anyone here? |
I don't think this is possible... maybe Easynews did some tricks to recover files posted by its users (same ip) but I don't see how they could recover the name of the files, especially if it's header protected archives... |
This is definitely not a problem with ngPost. So the obfuscation is not broken. It is simply not possible to obfuscate an upload completely if it is yenc encoded and the indexer goes the extra mile to parse the body of the message (and yenc-decode some of them) as well. |
Made some tests with easynews and files without file extension are not indexed. So ideal obfuscation would be like this:
In this case no file will be indexed by easynews. So to improve obfuscation, ngPost would need to do the filename obfuscation according to step 3 and when using filename obfuscation, the filename in the file subject in the generetade NZB file must be the original filename. I would also suggest that filename obfuscation should not obfuscate also the filenames within the rar. This should better be a seperate option. |
Suggestion to implement this the most easy way: If _obfuscateFileName is true simply write the md5 hash (or any oder hash) of the filename instead of the filename iself: ngPost/src/nntp/NntpArticle.cpp Line 66 in 7f4762b
If _obfuscateFileName is true simply write the md5 hash (or any oder hash but same as above) of the filename instead of the filename itself (this is to obfuscate file name in the article subject if "article obfuscation" is deactivated): Lines 99 to 102 in 7f4762b
and delete the following functions (because changing the filenames is not actually required): Lines 978 to 997 in 7f4762b
Lines 978 to 997 in 7f4762b
Don't think the remainder of the code need much other changes except that you need to pass the _obfuscateFileName bool to the NntpArticle and NntpFile::nameWithQuotes function. |
Ok, so it's kind of weird but i was working on my own nttp poster tool and while looking about how does ngpost that i'm used to, i stumble on this problem before even seen there was an issue post on the github. I just want to add something : Also, i though about some additional ideas to improve obfuscation :
|
Agree, this will strongly increase the obfuscation. But what if you don't use NZBGET for downloading but another tool who relays on the yenc header filename for yenc decoding, instead of the filenames in the NZB file? They will probably not be able to decode the file(s). By keeping the filenames constant for each file you will at least get the decoded files back with obfuscated names. And by guessing that the smallest file will probably be the .par2 file and renaming it to XXX.par2 you can then restore the original filenames.
Well, the articles still look "similar" and the yenc header still contains the part number. So if such articles are posted within a certain period of time, even in random order, you can still assume that they belong together and try to decode them. |
I suppose it's quite popular, because i stample on this comparing how i do things vs how does a nzb file that i got on an semi-private indexer and on this file, each segment used a different name inside the yenc. I also though of something but that involve a lot of preprocessing, ram or disk write : precalculate yenc part for the whole archives, and make "fake files" when you totaly reorder the order of the yenc part (like for a file, you use the first element of the 001, the second of the 004, ...) |
Btw, it's maybe out of scope of this issue, but i would be interested if you can give me an opinion, that my current take on obfuscation. And maybe that can give you some idea for your own project. My nzb seems to works fine with both Nzbget and sabnzb. I use splited 7z over multipart rar, because while rar are easier to blend in, i think that splited 7z header can only be read from the 001 archive and when i don't use password, i actually write garbage on few ko of the 7z.001, so if you want to know what are the file in the archives, you will need a repair. And without the nzb, getting enought pieces together to trigger a repair is not easy, because all yenc part are pre-generated and send in a semi-randomized order. |
I'm not in a state to read all that these days (complicated in my personal life). I thought I was bypassing yenc encoding when doing article obfuscation. if it is not the case it is easy to add. I could even do it for the next release. @Tensai75 could you confirm the third point of #175 I'm not entirely sure and don't know how to include you in the conversation directly there... cheers mate |
Indeed the yenc name is not obfuscated.... well easy to bypass it ;) a hint, it's around here that something should be done ;) |
Matthieu, can this be implemented and released (as a Windows compile please :-)) I'd even pay for the completely invisible variant. Maybe as a distraction from your personal life? I know, self-serving sob. |
i would absolutely love an update for this too! :D You are a champ for making this awesome GUI tool on windows, mruel! i would not be doing what i'm doing without it! when that's said, i do hope it gets updated at some point! |
@mbruel you alive? I have a list of bugs that I would appreciated you'd have a look at. One of them is kind of big, showing the tab green as in completed upload but the main rar file was not uploaded at all (and also shows like that in the tab detail view. |
@Abu3safeer you can't share builds without the code! I'm deleting your post |
You are correct @mbruel , that was a mistake from my side, the builds I shared was from https://github.com/Tr4il/ngPost/ |
I'm working on a new release for my community. This might be included or at least the fix for alpine and my own obfuscation solution |
Easynews did play their game, for that the patch is a necessity, and the returning of @mbruel to work on new version is amazing news. |
i would love it if you could make it so the checkbox: File Name Obfuscation keeps the extension of the file. i've noticed that allot of people uses nzbget, and if they don't enable deobfuscation manually, the files do come down super scrambled, and the extension is gone too. which makes them stress out :P Edit: even had a few people with sabnzbd not being able to deobfuscate the file, which also makes it 100% useless for them. |
@mbruel any progress/updates? I got issues... |
Just chiming in. The news provider usually don't parse the body, so if the articles aren't already being marked as spam, then they won't be marked as spam. It will break the yenc spec though. Cheers! |
@loungebob I got some personal issues plus a new work mission but I'll try to find some time to finish this summer. Not much to do to release the v5 ;) |
It’s alright, I’ve found ways to work around the issues. Looking forward to the next release. Keep your chin up and remember, it could always be worse. |
@mbruel any updates/news? things might be getting complicated on newsnet. |
not verified by myself as I don't have an account with that provider but I copy and paste the original post from the user who verified it.
"I noticed something
Ngposts obfuscation doesn't seem to work
I have obfuscation set to article
But whatever i upload, well it doesn't show up on public indexers like nzbindex and nzbking but Easynews search is able to find it
Even if obfuscation is set to article, the upload get found and indexed by Easynews search"
Other users have stated the same...
Please if this is how it looks like then this needs a fixed asap!!
The text was updated successfully, but these errors were encountered: