Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't page no service message on MZ signs #752

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

PaulJKim
Copy link
Collaborator

Summary of changes

Ad-hoc

Quick fix to prevent double-line paging on MZ signs during LTOTD treatment. This type of double paging causes a bug to occur in the vendor's software which leads to a crash and the signs going blank for some time.

Copy link

Coverage of commit 2382fc3

Summary coverage rate:
  lines......: 71.7% (1941 of 2708 lines)
  functions..: 74.3% (545 of 734 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/message/last_trip/no_service.ex                |80.0%      5|50.0%     4|    -      0
  lib/signs/utilities/last_trip.ex                           |87.8%     41| 100%     5|    -      0

Download coverage report

Copy link
Contributor

@cmaddox5 cmaddox5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@PaulJKim PaulJKim merged commit 6b3c844 into main May 10, 2024
2 checks passed
@PaulJKim PaulJKim deleted the pk/ltotd-hot-fix branch May 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants