Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Migrate to GTFS-rt predictions and locations feeds" #803

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

PaulJKim
Copy link
Collaborator

@PaulJKim PaulJKim commented Aug 2, 2024

Reverts #743

Unfortunately after deploying this migration last week, we started seeing some erroneous changes in predictions particularly with BRD predictions at terminals and passthrough announcements.

We should revert the migration for now to reduce the rider impact and to give us some space to do a deeper investigation into what could be causing the discrepancies in predictions when consuming the concentrate feeds vs the RTR feeds.

@PaulJKim PaulJKim requested a review from a team as a code owner August 2, 2024 18:53
Copy link

github-actions bot commented Aug 2, 2024

Coverage of commit 472b95e

Summary coverage rate:
  lines......: 73.5% (2118 of 2880 lines)
  functions..: 76.7% (585 of 763 functions)
  branches...: no data found

Files changed coverage rate:
                                                             |Lines       |Functions  |Branches    
  Filename                                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================================
  lib/content/message/predictions.ex                         |71.9%    128| 100%    17|    -      0
  lib/fake/httpoison.ex                                      |74.5%     47|57.1%     7|    -      0
  lib/predictions/last_trip.ex                               |78.6%     14| 100%     3|    -      0
  lib/predictions/prediction.ex                              | 100%      1| 100%     2|    -      0
  lib/predictions/predictions.ex                             | 100%     40| 100%     6|    -      0
  lib/signs/utilities/predictions.ex                         |98.6%     71| 100%    12|    -      0

Download coverage report

@PaulJKim PaulJKim merged commit 53bdd70 into main Aug 2, 2024
2 checks passed
@PaulJKim PaulJKim deleted the revert-743-pk/migrate-from-rtr-to-gtfs-rt branch August 2, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants