Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 내 정보 수정에 이미지 변경 로직을 구현하라 #544

Merged
merged 1 commit into from
Oct 14, 2022
Merged

feat: 내 정보 수정에 이미지 변경 로직을 구현하라 #544

merged 1 commit into from
Oct 14, 2022

Conversation

saseungmin
Copy link
Member

  • 이미지 변경 버튼 클릭시 사용자 프로필 이미지 변경
  • 이미지가 이미 존재한 경우에는 기존의 이미지 삭제 후 새로운 이미지 업로드

@saseungmin
feat: 내 정보 수정에 이미지 변경 로직을 구현하라
aeb2c6b 
- 이미지 변경 버튼 클릭시 사용자 프로필 이미지 변경
- 이미지가 이미 존재한 경우에는 기존의 이미지 삭제 후 새로운 이미지 업로드
@vercel
Copy link

vercel bot commented Oct 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
soople ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 2:17PM (UTC)

@saseungmin saseungmin added the Feat/Function 새로운 기능 / New Feature label Oct 14, 2022
@saseungmin saseungmin linked an issue Oct 14, 2022 that may be closed by this pull request
내 정보 수정 > 이미지 변경 #543
Open
@saseungmin saseungmin self-assigned this Oct 14, 2022
@github-actions
Copy link

Bundle Sizes

Compared against ca4eedf

Route: No significant changes found

Dynamic import: No significant changes found

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (aeb2c6b) compared to base (ca4eedf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #544   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          197       197           
  Lines         3620      3635   +15     
  Branches       407       410    +3     
=========================================
+ Hits          3620      3635   +15
Impacted Files Coverage Δ
src/styles/GlobalStyles.tsx 100.00% <ø> (ø)
src/components/myInfo/ImageSetting.tsx 100.00% <100.00%> (ø)
src/containers/myInfo/MyInfoSettingContainer.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

⚡️ 1 Lighthouse report!

Category Score
🔴 Performance 26
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.7 s
🔴 Time to Interactive 15.2 s
🔴 Speed Index 9.0 s
🔴 Total Blocking Time 8,860 ms
🔴 Largest Contentful Paint 15.7 s
🟢 Cumulative Layout Shift 0

⚡️ 2 Lighthouse report!

Category Score
🔴 Performance 44
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 8.8 s
🟢 Speed Index 3.3 s
🔴 Total Blocking Time 1,150 ms
🔴 Largest Contentful Paint 11.2 s
🟢 Cumulative Layout Shift 0

⚡️ 3 Lighthouse report!

Category Score
🔴 Performance 41
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟠 PWA 80
Category Score
🟢 First Contentful Paint 1.6 s
🔴 Time to Interactive 9.7 s
🟠 Speed Index 3.9 s
🔴 Total Blocking Time 1,320 ms
🔴 Largest Contentful Paint 11.5 s
🟢 Cumulative Layout Shift 0

@saseungmin saseungmin merged commit 5e30bfd into main Oct 14, 2022
@saseungmin saseungmin deleted the feat/issue-543 branch October 15, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saseungmin saseungmin

Labels
Feat/Function 새로운 기능 / New Feature size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

내 정보 수정 > 이미지 변경
1 participant
@saseungmin