turn most deps into weakdeps #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! Do you know whether names like StatisticsExt can or cannot cause problems by being used elsewhere? Many packages shove their own name into the ext name. |
|
There was a short period of time around 1.9 release, when some tools like PackageCompiler didn't work with duplicated extensions names. Somehow, this situation ended up so ingrained... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150.
I got so used to AxisKeys bringing lots of these packages as dependencies, didn't even think that with 1.9 they can be made optional :) Only noticed after seeing the recent issue opened here.
Tests (should) pass on both 1.6 and 1.9. Failures on 1.10 unrelated: there's a known Julia issue with new ambiguities JuliaLang/julia#52386 JuliaLang/julia#52263 JuliaSparse/SparseArrays.jl#431.