Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor doesn't have vertical scrolling anymore #277

Closed
asrelo opened this issue Nov 7, 2024 · 2 comments
Closed

Editor doesn't have vertical scrolling anymore #277

asrelo opened this issue Nov 7, 2024 · 2 comments

Comments

@asrelo
Copy link

asrelo commented Nov 7, 2024

Before the series of releases in November, the editor frame had vertical scrolling. The layout never overflowed outside viewport (at least in my experience on wide desktops); when text in the editor was too long, the editor frame had scrolling.

Now, when text in the editor is too long, the editor resizes, causing the layout to overflow vertically, and page scrolling kicks in. Major undesired effects are that the search panel of the editor and list of errors/warnings end up on the very bottom of the page, and the rendered image ends up in the middle of the page.

Can be reproduced with any long text in the editor; the example graph "Clusters" might be enough.

Tested in Chrome 130.0, Firefox 130.0 on different screen sizes in horizontal orientation.

@mdaines
Copy link
Owner

mdaines commented Nov 7, 2024

Thanks for reporting this. I just reverted b2874f7 which introduced this issue.

mdaines added a commit that referenced this issue Nov 7, 2024
This is meant to fix #277. #275 moved the app element inside a root element so that it could be referenced more easily in the App component, but that meant its height was no longer determined by the outermost grid.
@mdaines mdaines closed this as completed in 73dc6a0 Nov 7, 2024
@mdaines
Copy link
Owner

mdaines commented Nov 7, 2024

I deployed #278 which should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants