Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility compliance #39

Open
smartm0use opened this issue Jan 27, 2017 · 3 comments
Open

Accessibility compliance #39

smartm0use opened this issue Jan 27, 2017 · 3 comments

Comments

@smartm0use
Copy link

smartm0use commented Jan 27, 2017

Hello, I use your calendar since it was a pull request on Semantic-UI repository.
I have a request for you: can you make your addon compliant with accessibility standards (WCAG 2.0)?

AChecker returns the following errors:

Check 244: Data table with both row and column headers does not use scope to identify cells.
Repair: Add scope attributes to header cells so they identify the cells that relate to the header.

Line 553, Column 237:
<table class="ui celled center aligned unstackable table seven column day"><thead><tr><th colspan="7 ...
Line 608, Column 153:
<table class="ui celled center aligned unstackable table seven column day"><thead><tr><th colspan="7 ...

Check 245: Data table with more than one row/column of headers does not use id and headers attributes to identify cells.
Repair: Add id and headers attributes to table cells so they identify the cells that relate to the headers.

Line 553, Column 237:
<table class="ui celled center aligned unstackable table seven column day"><thead><tr><th colspan="7 ...
Line 608, Column 153:
<table class="ui celled center aligned unstackable table seven column day"><thead><tr><th colspan="7 ...

Thank you.

@smartm0use
Copy link
Author

Hello, can you fix this?

@AaronHarris
Copy link

Pull requests are surely encouraged if it's only a few changes that need to be made!

@smartm0use
Copy link
Author

I do not know what kind of changes to add to the source code to make it compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants