Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firefox data for char attributes of HTML element #21828

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

@queengooborg queengooborg added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 2, 2024
@teoli2003
Copy link
Contributor

So, why the implementation comment?

@queengooborg
Copy link
Collaborator Author

The impl_url is just something to track bugs, commits, etc. for when the feature was implemented -- they're not meant to be an indication of an issue with the feature, so no harm in leaving them, but also no harm in removing them either!

@Elchi3
Copy link
Member

Elchi3 commented Jan 22, 2024

That impl bug is still open, though?

@queengooborg queengooborg marked this pull request as draft January 28, 2024 16:56
@caugner
Copy link
Contributor

caugner commented Nov 19, 2024

Firefox doesn't support this deprecated feature, see this test case. The observed behavior (the attributes can be set and get) can be explained by this bug and this commit that landed in Firefox 8. Before that, ch defaulted to "." since Firefox 1 (see this bug).

@caugner
Copy link
Contributor

caugner commented Nov 19, 2024

@queengooborg Would you like to document the get/set behavior with partial implementation?

@github-actions github-actions bot added the size:s [PR only] 7-24 LoC changed label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:s [PR only] 7-24 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants