Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string.concat() is not useful #37122

Merged
merged 2 commits into from
Dec 6, 2024
Merged

string.concat() is not useful #37122

merged 2 commits into from
Dec 6, 2024

Conversation

Yanko1013
Copy link
Contributor

Description

Just add the {{optional_inline}}, same as "Web/JavaScript/Reference/Global_Objects/Array/concat". :)

Add {{optional_inline}}, same as array/concat
@Yanko1013 Yanko1013 requested a review from a team as a code owner December 6, 2024 17:19
@Yanko1013 Yanko1013 requested review from Josh-Cena and removed request for a team December 6, 2024 17:19
@github-actions github-actions bot added Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed labels Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Preview URLs

(comment last updated: 2024-12-06 22:56:15)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of marking it optional, we need to explicitly point out that it's not a useful operation, so I've added some text instead. Thanks for bringing this up!

@Josh-Cena Josh-Cena changed the title Update index.md string.concat() is not useful Dec 6, 2024
@Josh-Cena Josh-Cena merged commit c7ee557 into mdn:main Dec 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants