Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the aria-live example in page #37167

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

move the aria-live example in page #37167

wants to merge 7 commits into from
+309 −16

Conversation

dletorey
Copy link
Contributor

Description

  • moved the aria-live example into the page

Motivation

  • Helping @bsmth with the migration of examples into content
  • First example moved to make sure I am doing this correctly.

@dletorey dletorey requested a review from a team as a code owner December 10, 2024 17:14
@dletorey dletorey requested review from scottaohara and removed request for a team December 10, 2024 17:14
@github-actions github-actions bot added Content:Learn:Accessibility Accessibility documentation in the Learn Area size/m [PR only] 51-500 LoC changed labels Dec 10, 2024
@dletorey dletorey requested review from bsmth and removed request for scottaohara December 10, 2024 17:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-12-11 16:49:52)

bsmth
bsmth approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Two comments for you to look at, but looking great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dletorey @bsmth