missing .add method on hasMany relation

[ebarault]

Hi Jonathan,

Thx for providing this mixin! I am currently developping a similar import mixin, but based on json files, self-including the mapping schema.

I noticed in your code what could be an error.
here, you use a .add method on a hasMany relation, which i believe does not exist.

 I doubled checked this since in my code I need to deal with the hasMany relation in a different manner than hasManyThrough and hasAndBelongsToMany

[jonathan-casarrubias]

Hey @ebarault thanks for reaching out.

Hey so, you are right... There is an add method but just for hasManyThrough and hasAndBelongsToMany, I just verified and for hasMany should be create instead of add.

This is stated here: https://strongloop.com/strongblog/defining-and-mapping-data-relations-with-loopback-connected-models/

It looks like an easy fix, maybe you could help by adding a pull request on this? so this can be fixed faster.

I will be integrating all of these modules and mixins within the new FireLoop CLI Tool, so I may be able to fix it in a near future but not as soon as possible.

Cheers
Jon

[ebarault]

@jonathan-casarrubias hey why not ! 👍
I'll try to do it next week.

Nice initiative this FireLoop thing by the way, i see a lot of the usual stuff i integrate with loopback already in. I'd be interested to join the effort.