-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement prefix
config key
#2
base: main
Are you sure you want to change the base?
implement prefix
config key
#2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just adding some pre-emptive explanations.
I'm getting this error when running
Update: noticed that also happens on |
Okay I fixed the issue with tests in #3 - could you rebase and check if my PR makes sense? Then I'll release all those updates at once. |
Ah, and somewhere in the docs we should mention that feature of the prefix, I guess.
But really thanks for contributing something here :) |
2279955
to
1c7e54a
Compare
done - I have pushed my changes applied over your pr #3 (rebased). Not sure if that's what you mant. I also ran the tests (+acctests) again and it seemed to be working just fine. I was using this PR in my work for some time and didn't notice any problems so far. and last thing about the docs - I wasn't sure how to do that trough tfplugindocs, I'll try to figure it out. Thank you :) |
Cool. Yeah I don't know how to put it into the docs either. This repo is the first time I'm fiddling with terraform providers. 😆 |
Closes #1