Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement prefix config key #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arturtamborski
Copy link

Closes #1

Copy link
Author

@arturtamborski arturtamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding some pre-emptive explanations.

docs/data-sources/password.md Show resolved Hide resolved
pass/helpers.go Show resolved Hide resolved
pass/provider.go Show resolved Hide resolved
@toabi
Copy link
Member

toabi commented Dec 1, 2022

I'm getting this error when running make testacc:

❯ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20  -timeout 120m
?   	github.com/mecodia/terraform-provider-pass	[no test files]
=== RUN   TestDataSourcePassword
    data_source_password_test.go:12: Step 1/2 error: Error running pre-apply plan: exit status 1
        
        Error: failed to read password at tf-pass-provider/secret/data: entry is not in the password store
        
          on terraform_plugin_test.tf line 11, in data "pass_password" "test":
          11: data "pass_password" "test" {
        
        
--- FAIL: TestDataSourcePassword (0.91s)
=== RUN   TestResourcePassword
--- PASS: TestResourcePassword (21.62s)
FAIL
FAIL	github.com/mecodia/terraform-provider-pass/pass	22.925s
FAIL
make: *** [testacc] Error 1

Update: noticed that also happens on main.

@toabi
Copy link
Member

toabi commented Dec 2, 2022

Okay I fixed the issue with tests in #3 - could you rebase and check if my PR makes sense? Then I'll release all those updates at once.

@toabi
Copy link
Member

toabi commented Dec 2, 2022

Ah, and somewhere in the docs we should mention that feature of the prefix, I guess.

But really thanks for contributing something here :)

@arturtamborski arturtamborski force-pushed the issue-1-mount-point-in-provider-config branch from 2279955 to 1c7e54a Compare December 2, 2022 17:15
@arturtamborski
Copy link
Author

done - I have pushed my changes applied over your pr #3 (rebased). Not sure if that's what you mant. I also ran the tests (+acctests) again and it seemed to be working just fine.

I was using this PR in my work for some time and didn't notice any problems so far.

and last thing about the docs - I wasn't sure how to do that trough tfplugindocs, I'll try to figure it out.

Thank you :)

@toabi
Copy link
Member

toabi commented Dec 2, 2022

Cool. Yeah I don't know how to put it into the docs either. This repo is the first time I'm fiddling with terraform providers. 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to specify mount point in provider block
2 participants