Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'name' field in Sources to 'Domain' (or better, 'cannonical domain') , add validator on ui #830

Open
pgulley opened this issue Oct 22, 2024 · 0 comments
Assignees

Comments

@pgulley
Copy link
Member

pgulley commented Oct 22, 2024

Some sources, particularly those with url_search_strings, end up with descriptive names in the 'name' field instead of their canonical domain. This is mostly a case of poorly documented behavior- but we use the 'name' field to generate the 'canonical domain' filters when we query elasticsearch- so these sources are broken.
Changing the field name to something more descriptive, and adding a validator to make sure users are entering the right kind of data, will keep this from happening again.

I'll also spin up some more source health tickets to fix the cases where this has already happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants