Allow user_profile endpoint to be accessible via api #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evan-Leon
added
bug
|
Can you say more about the reason this is being added? Just thinking forward to when we focus on security more and trying to be defensive in the situation where someone loses/publishes their API key. Is there any data returned by this that is potentially sensitive or unnecessary and should be stripped before returning? ie. password-hash, last-login, full name, email, date joined? |
|
This was added to satisfy a test in the API client. If accessed via API will not return any relevant information, but will now accessible with token and shouldn't fail test (in response to issue #740) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receive a non error status response from user_profile endpoint via API w/ token.