To unmap from in-container to on-host, use _map_targ_src #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md import statements
…nance Feature/provenance
Bumps [requests](https://github.com/requests/requests) from 2.7.0 to 2.20.0. - [Release notes](https://github.com/requests/requests/releases) - [Changelog](https://github.com/psf/requests/blob/master/HISTORY.md) - [Commits](psf/requests@v2.7.0...v2.20.0) Signed-off-by: dependabot[bot] <[email protected]>
Increment version
…ip/python/examples/provenance/filter_svc/requests-2.20.0 Bump requests from 2.7.0 to 2.20.0 in /python/examples/provenance/filter_svc
1. Change a bit of terminology 2. Add node list in the graph. One graph may has isolated node. It's also good for evaluation.
Update nodes
…s/spongezhang-comment Update provenance.proto based on comments for Columbia team.
…client Added provenance API changes, provenance client, and refactored CLI
…les and updates .gitignore to use correct syntax to ignore *.swp
removes 'yield from' for python2 compatibility. removes *.swp
…s/pb_fix fix broken provenance services python file
The unmap functions used the _map_src_targ function with reversed arguments. However, that caused a check whether the target side is a directory on the host, which is irrelevant and can cause errors. A new function _map_targ_src still does the directory check, but only on the host side.
|
I guessed that the directory check was for a good reason, so this approach is to add a new function that still does the directory check. If the directory check isn't crucial, another approach is just to remove it from the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unmap functions used the _map_src_targ function with reversed
arguments. However, that caused a check whether the target side is a
directory on the host, which is irrelevant and can cause errors. A
new function _map_targ_src still does the directory check, but only on
the host side.