Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality of getting people as an iterator in cht-datasource #9238

Closed
sugat009 opened this issue Jul 3, 2024 · 4 comments
Closed
Assignees
Labels
Type: Feature Add something new

Comments

@sugat009
Copy link
Member

sugat009 commented Jul 3, 2024

Is your feature request related to a problem? Please describe.

This feature is part of a bigger feature of the creation of API endpoints for getting contacts by type. (#9193)
The target of this feature is to have the functionality of getting people using cht-datasource as an AsyncIterator or something similar that can fetch data in batches.

Describe the solution you'd like

Person.v1.getAllAsync();

Describe alternatives you've considered

Additional context

@jkuester
Copy link
Contributor

As noted here: #9237 (comment)

I think we should go for a function signature like:

const getAll = () => AsyncGenerator<Person.v1.Person, void>

Also, FTR, I have found this blog post to be very helpful in wrapping my mind around async interators/generators.

@garethbowen
Copy link
Member

@sugat009 Should this be in the release milestone?

@sugat009
Copy link
Member Author

@garethbowen yes.

@sugat009 sugat009 added this to the 4.11.0 milestone Aug 23, 2024
@jkuester
Copy link
Contributor

I am removing this from the 4.11 milestone since it is covered already by #9241.

@jkuester jkuester removed this from the 4.11.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Add something new
Projects
Status: Done
Development

No branches or pull requests

3 participants