Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WakefulService and friends to reuse code more #153

Open
SCdF opened this issue Dec 13, 2019 · 1 comment
Open

Refactor WakefulService and friends to reuse code more #153

SCdF opened this issue Dec 13, 2019 · 1 comment
Labels
Type: Technical issue Improve something that users won't notice

Comments

@SCdF
Copy link
Contributor

SCdF commented Dec 13, 2019

WakefulService is a service that is executed on wake periodically, that deals with polling API to communicate any webapp terminating messages in gateway, as well as taking any webapp originating messages that API returns and sending them on.

We now also do this in the IntentProcessor, attempting to communicate with API and send on any resulting messages whenever we get an incoming SMS.

We should refactor these two classes so they reuse code more, instead of the current copy / paste job that the IntentProcesser is powered by atm.
@SCdF SCdF added the Type: Technical issue Improve something that users won't notice label Dec 13, 2019
@SCdF SCdF mentioned this issue Dec 13, 2019
Merged
@SCdF
Copy link
Contributor Author

SCdF commented Jan 28, 2020

#147 is probably pretty related, might as well tie these together and get them done in one go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Technical issue Improve something that users won't notice
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SCdF