-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping Options Service Missing, canCalculate is never called. #9598
Comments
You are right, we haven't added backend support for calculated prices on shipping options yet. This is something we will look into in the coming days or right after the official release :) |
assuming this will be post 2.0 release? Is there any indication in the docs what other features like this may not yet be fully developed. The 2.0 docs lead me to believe that a fulfillment service would be functional if I developed it correctly and added it to the configuration. Just want to know what else is lacking in the official 2.0 release. |
I want to use Medusa for my next project but I really need this feature. Will it be available in the next couple of days? |
I also noticed that the medusa sdk throws an error if there's no price for a shipping option, even if that price is calculated. |
Is this bug fixed ?! |
Not that I am aware of. I've postponed trying to get it to work until some official word about the status of plugin modules like this and their future. If they plan on supporting the existing APIs or if there is some other model that should be followed instead. |
@olivermrbl any updates? It's been a few days since 2.0 release... |
is this addressed at all with the latest releast https://github.com/medusajs/medusa/tree/v2.1.0? I would like official feedback before I wast time on trying to see if this works now or not. Maybe with the commit #10432 ?? |
@olivermrbl was this resolved in the 2.1.1 release??
|
@amaster507, this is part of the next release, likely shipping later this week. My apologies for not following up. |
@olivermrbl - Can you give us update about this issue? Thanks |
I think it's fixed in v2.1.3, is that right? |
Hey guys, this issue is fixed in the latest release. Will close this issue now. |
I'm having a similar problem to this in v2.1.3, where |
I am now having the same issue with |
Hey @bibergo I would advise you to update to the latest version, and if it's still not working then please open a new issue with all your setup's details so that we can provide better support. |
Bug report
Describe the bug
The
shipping-options
service seems to be missingSystem information
Medusa version (including plugins):
Node.js version: 20
Database: postgres
Operating system: linux host with docker containers running node/postgres/redis/etc.
Browser (if relevant): Chrome/NA
Steps to reproduce the behavior
AbstractFulfillmentProviderService
with thecanCalculate
and other methods.medusa-config.js
to use the custom fulfillment provider service.Expected behavior
The custom fulfullment
canCalculate
should be called when listing shipping options for a calculated options.Screenshots
See Discussion linked below
Code snippets
#9495
Additional context
From looking at the 1.x repo, the
canCalculate
method is called withing thepackages > medusa > src > services > shipping-options.ts
And this gets called fromvalidatePriceType_
which gets called fromvalidateAndMutatePrice
, etc. None of these seem to exist anymore in the v2 repo. Obviously there was a refactor, and I believe these were not added back in after the refactor.The text was updated successfully, but these errors were encountered: