Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pricing): add null conditions for deleted at during price calculations #10896

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix(pricing): add null conditions for deleted at during price calculations #10896

merged 2 commits into from
Jan 9, 2025

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 9, 2025 •
edited
Loading

what:

The pricing calculations are currently returning deleted prices when calculating prices. This PR fixes that by scoping the query by the price's deleted_at

RESOLVES CMRC-832
FIXES #10844

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 83095f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 65 packages
Name Type
@medusajs/pricing Patch
integration-tests-http Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch
@medusajs/telemetry Patch
@medusajs/admin-bundler Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/dashboard Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 0:51am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 9, 2025 0:51am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:51am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:51am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:51am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:51am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 0:51am

@riqwan riqwan marked this pull request as ready for review January 9, 2025 12:49
@riqwan riqwan requested a review from a team as a code owner January 9, 2025 12:49
@riqwan riqwan merged commit 3fec01a into develop Jan 9, 2025
23 checks passed
This was referenced Jan 9, 2025
Open
Open
Open
Open
Merged
Closed
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@riqwan @noubase
fix(pricing): add null conditions for deleted at during price calcula…
4da020f 
…tions (medusajs#10896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

@mrnbpt mrnbpt Awaiting requested review from mrnbpt mrnbpt is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
2 participants
@riqwan @carlos-r-l-rodrigues