Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ports to decline a connection #74

Open
bergie opened this issue Oct 1, 2013 · 7 comments
Open

Allow ports to decline a connection #74

bergie opened this issue Oct 1, 2013 · 7 comments

Comments

@bergie
Copy link
Contributor

bergie commented Oct 1, 2013

In NoFlo we have situations where a port will not allow a new connection. This means that in Dataflow too we need to be able to decline a connection.

@forresto
Copy link
Member

forresto commented Oct 1, 2013

What situation?

@bergie
Copy link
Contributor Author

bergie commented Oct 1, 2013

@forresto some examples (note that some of this will change with noflo/noflo#90)

Of course the other option would be to always destructively remove whatever was there when dragging a new connection in.

@forresto
Copy link
Member

forresto commented Oct 1, 2013

Seems better to reject the new.

I see #72 (remove state/iip) is related as well.

@bergie
Copy link
Contributor Author

bergie commented Oct 1, 2013

Another affected issue is #63

@hacfi
Copy link

hacfi commented Oct 1, 2013

Should there be some kind of notification system informing the user or do you want to use Dataflow.log(..) for that?

@bergie
Copy link
Contributor Author

bergie commented Oct 1, 2013

@hacfi I think the ports that decline connections should simply not be connectable, i.e. no highlight (#63, #37), and dropping on top of them shouldn't establish a connection.

However, we do have a notification mechanism already in Dataflow, for example:

screenshot 2013-10-01 at 13 46 26

@hacfi
Copy link

hacfi commented Oct 1, 2013

@bergie I checked out the demos and noticed the highlighting..thanks! I was mainly working with the demo of this repo which doesn’t use highlighting (yet!?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants