Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor walking for better responsivenes #1028

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: refactor walking for better responsivenes #1028

wants to merge 2 commits into from

Conversation

nekiro
Copy link
Collaborator

@nekiro nekiro commented Jan 9, 2025 •
edited
Loading

Description

More smooth, better, refactored walking

Behavior

Actual

Walking is laggy

Expected

Should be smooth

Fixes

Fix #1027

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@nekiro nekiro force-pushed the fix-next-walk-event branch from afacc0c to b47ed98 Compare January 9, 2025 11:19
Zbizu
Zbizu approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's working, I had to set this one to minimum as well:
obraz

recording on otcr:

2025-01-09.17-00-00.mp4

@nekiro nekiro force-pushed the fix-next-walk-event branch from b47ed98 to aa7f8dc Compare January 9, 2025 16:13
@kokekanon
Copy link
Collaborator

kokekanon commented Jan 9, 2025 •
edited
Loading

me test :
server : main repo otland
otcr:

pressing both keys (not holding down one key permanently)

2025-01-09.12-57-04_1.mp4

@mehah
Copy link
Owner

mehah commented Jan 9, 2025

@nekiro
the feature that puts the delay on the first step has stopped working.
image

because that was what reset the step when you didn't walk for 150ms.
image

@nekiro nekiro changed the title fix: schedule next walk event for smoother turning fix: refactor walking for better responsivenes Jan 10, 2025
@nekiro
Copy link
Collaborator Author

nekiro commented Jan 10, 2025 •
edited
Loading

I have reworked the whole walking, it seems better to me. I also deleted some useless options.
It performs poorly on high ping though, so converting this into draft.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nekiro nekiro marked this pull request as draft January 10, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luanluciano93 luanluciano93 luanluciano93 approved these changes

@Zbizu Zbizu Zbizu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next walk is not getting queued while changing directions
5 participants
@nekiro @kokekanon @mehah @Zbizu @luanluciano93