Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npc trade #939

Closed
1 of 5 tasks
bateunatrave opened this issue Oct 19, 2024 · 4 comments
Closed
1 of 5 tasks

npc trade #939

bateunatrave opened this issue Oct 19, 2024 · 4 comments
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@bateunatrave
Copy link

Priority

Low

Area

  • Data
  • Source
  • Docker
  • Other

What happened?

When the NPC has many items in the trade, there is an accumulation of items and a large drop in FPS.

image

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bateunatrave bateunatrave added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 19, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Oct 19, 2024
@kokekanon
Copy link
Collaborator

kokekanon commented Oct 19, 2024

What is your version and protocol?

this npc how many items does it sell/buy ?

error terminal ?

@bateunatrave
Copy link
Author

canary ? opentibiabr/canary#2837

What is your version and protocol?

this npc how many items does it sell/buy ?

error terminal ?

version 13x
the npc has more than 100 items
if the 'show all' option is unchecked
the bug marked with a circle is correct because only the items that the character has for sale appear

@kokekanon
Copy link
Collaborator

kokekanon commented Oct 19, 2024

I confirm bug, to repoduce it in 11.00 or 13.40

/goto The Lootmonger

hi
trade

release 3.5 same
image

after 769 widgets in the grid the error occurs

       if key == 768 then
            break
        end

kokekanon added a commit to kokekanon/otclient.readme that referenced this issue Oct 20, 2024
@kokekanon
Copy link
Collaborator

kokekanon commented Oct 20, 2024

"accumulation of items and a large drop in FPS."

(I fixed the visual bug, not the performance bug.)
test you performance
#940

my pc is not the best one to measure that.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

2 participants