Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armenian letters should be lowercased #325

Open
ManyTheFish opened this issue Jan 23, 2025 · 0 comments · May be fixed by #328
Open

Armenian letters should be lowercased #325

ManyTheFish opened this issue Jan 23, 2025 · 0 comments · May be fixed by #328
Labels
good first issue Good for newcomers

Comments

@ManyTheFish
Copy link
Member

The LowercaseNormalizer is not configurated to lowercase the Armenian characters as we can see below:

fn should_normalize(&self, token: &Token) -> bool {
// https://en.wikipedia.org/wiki/Letter_case#Capitalisation
matches!(token.script, Script::Latin | Script::Cyrillic | Script::Greek | Script::Georgian)
&& token.lemma.chars().any(char::is_uppercase)
}
}

We should activate the LowercaseNormalizer for the Armenian Script.

@ManyTheFish ManyTheFish added the good first issue Good for newcomers label Jan 23, 2025
NarHakobyan added a commit to NarHakobyan/charabia that referenced this issue Feb 7, 2025
@NarHakobyan NarHakobyan linked a pull request Feb 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant