-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework heed to be lightweight and simpler to maintain #128
Conversation
39f360e
to
1fd8522
Compare
I was trying this branch yesterday and it was returning For example, if you run
whereas it works in the main branch it works as expected
Looking at the hexdump of the datafile you can see
but the main branch gives
Maybe I'm doing something stupid... but I wanted to mention in case I'm not. Edit: testing was done using x64 linux, gcc 12.1, rustc 1.60.0 (7737e0b5c 2022-04-04 |
Hey @arthurprs, Thank you very much for trying out this work-in-progress branch! I indeed had the same kind of issues and it looked like it was related to the fact that the folder to store the LMDB environment was already there, I fixed the whole list of tests by using a temporary directory. But it is very strange, I moved from the |
23979c5
to
42d2237
Compare
Hey @arthurprs, Thank you again for testing this new branch, and for finding this potential issue. Unfortunately, I wasn't able to trigger the same issue when using I would be glad if you try out this branch and tell me whether your program is correctly working or is completely broken. Don't expect to be able to read a previous version of an LMDB database. Note that the API is changing a lot and I didn't document that for now, I will do it once this PR is merged. |
64d8a4b
to
6ef5bbe
Compare
Closes #56
6ef5bbe
to
fc0720d
Compare
Hi! I've seen that this PR uses If you find any problem with the crate, feel free to open an issue or sending me a DM, I'll be more than happy to help! :) |
Thank you very much @Techie-Pi. I just updated the dependency to use a safer source which is crates.io 🙏 |
580168f
to
31e4ddb
Compare
For information, I will merge this PR with the |
8dc5c2b
to
6aa9c21
Compare
And here we are, heed v0.20.0-alpha.0 just released on crates.io 🎉 |
This PR closes #127, closes #94, closes #56, closes #88, closes #40, closes #94, closes #132, closes #138, closes #95.
MDB_RESERVE
.BEU32
xOwnedType
combo by new simpler codecs.RoTxn
is necessary.RwTxn::abort
function, must not return aResult
as LMDB can't fail when doing so.BadOpenOptions
error must be more helpful and should maybe return the database with the expected options.Debug
on most of the structs.RwTxn
, the parent txn replaces the env one.