-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best type hint for setting return #573
Comments
I'm also getting a deprecation on Meilisearch\Contracts\Data "exception" => ErrorException { |
@tacman and how this is related to the original issue? :) |
related in that they both refer to return type declaration, yes? Just trying to help cleanup the sometimes noisy deprecation warnings! Was I wrong to add this here? |
It would be easier to track as a separate issue :) Also - does it fix your issue if you'd add |
okay, though they seem related to me. I guess I could reference one from the other. I assume that fix would work, but I haven't forked it for testing, so I was just looking for a place to report the deprecation. |
Description
Following this comment from @norkunas the type hints of returns are not indicated in the HandleSettings file. It might be a good idea to specify that the latter return tasks.
Possible solutions
This could be also done in other files
The text was updated successfully, but these errors were encountered: