-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugin to be compatible with Cypress 10 #215
Comments
I found my way to this issue. I believe this is the root cause for the error:
This plugin hasn't been updated for a while. Hopefully it can support v10. |
Hello. I tried this plugin for 9.6.0. Works great! But when I upgraded to 10.4.0 it showing me this error whenever I add the import 'cypress-plugin-snapshots/commands'; in e2e.js. All else in npm install and cypress.config.js are okay. Do we have estimated timeline for this? (I removed the sensitive information in the screenshot) Tried to reinstall |
This plugin is not actively maintained. I suggest switching to an alternative like https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff |
Hello @dhulme I tried https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff on our project and works great in local. However when I try t o run it in CircleCI, we're using Docker, I'm getting this error. Not sure which esbuild should we install for this package to run in CI. |
@faith-berroya I'm not sure how the plugin could be generating this error. I don't think esbuild is required for the plugin. It's not clear from your logs what is causing the error. You could try doing |
Oofff false alarm. Thank you for the hint @dhulme I'm able to debug it now. It's a dependency on @badeball/[email protected]. Thank you! 😄 |
Hi @dhulme do we have a setting for https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff to compare to a baseline image? I noticed it's good for several runs but lately I've been getting wrong images as the baseline. Do I have to run until I get all correct images with: Once I have them I can remove the I can check them locally when I'm testing. But I cannot check it anymore if it is continuously updating in CircleCI. Or is there an additional setting where we could save a baseline image into another folder then call and compare from the current run? Correct: |
@faith-berroya if you don't specify |
Sure @dhulme I opened a ticket there as well. Thank you! FRSOURCE/cypress-plugin-visual-regression-diff#87 |
Hi there! I hope this helps @admah. I had the same issue as @amir20 This workaround helped me fix the issue in Cypress v10.6.0 // cypress.config.js
const { defineConfig } = require("cypress");
const { initPlugin } = require('cypress-plugin-snapshots/plugin');
module.exports = defineConfig({
e2e: {
setupNodeEvents(on, config) {
// implement node event listeners here
initPlugin(on, config);
return config;
},
excludeSpecPattern: [
'**/snapshots/*',
'**/__image_snapshots__/*',
],
},
}); The only other modification was in // commands.js
import 'cypress-plugin-snapshots/commands'; |
Hello 👋 I'm writing on behalf of the Cypress DX team. We wanted to notify you that some changes may need to be made to this plugin to ensure that it works in Cypress 10.
For more information, here is our official plugin update guide.
The text was updated successfully, but these errors were encountered: