diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index a4b869fc28202b..7932df4400a9f4 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -4,7 +4,7 @@ Thanks for submitting a pull request! Please provide enough information so that Explain the **motivation** for making this change. What existing problem does the pull request solve? -Example: When "Adding a function to do X", explain why it is necessary to have a way to do X. +Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** diff --git a/bots/IssueCommands.txt b/bots/IssueCommands.txt index 1f7a4a59857d44..c61009870848f1 100644 --- a/bots/IssueCommands.txt +++ b/bots/IssueCommands.txt @@ -28,6 +28,9 @@ close comment {author} tells me to close this issue. If you think it should still be opened let us know why. close +@facebook-github-bot bugfix +Hey {issue_author}, if you're sure this is a bug can you send a PR with a fix? We're a small team and rely on the community to fix issues that don't affect fb apps. + @facebook-github-bot reopen comment Okay, reopening this issue. reopen diff --git a/docs/PullRequestGuidelines.md b/docs/PullRequestGuidelines.md index 6821059164e72a..ee9a1695236dd6 100644 --- a/docs/PullRequestGuidelines.md +++ b/docs/PullRequestGuidelines.md @@ -9,4 +9,10 @@ Does the code style match the [Style guide](https://github.com/facebook/react-na Does the pull request add a completely new feature we don't want to add to the core and maintain? Ask the author to release it a separate npm module and close the PR. Example: [#2648](https://github.com/facebook/react-native/pull/2648). -Does the pull request do several unrelated things at the same time? Ask the author to split it. \ No newline at end of file +Does the pull request do several unrelated things at the same time? Ask the author to split it. + +Is the PR old and need rebasing? Ask the author "Can you rebase please?" and add the label "Needs response from author". + +Is a PR waiting for a response from author (usually has label "Needs response from author") and there's no reply in last 30 days? Close it with the [bookmarklet](https://github.com/facebook/react-native/blob/master/bots/pr-inactivity-bookmarklet.js). Examples: [#3066](https://github.com/facebook/react-native/pull/3066), [#1099](https://github.com/facebook/react-native/pull/1099). + +Is the PR old and waiting for review? Review it or cc someone who might be able to review.