Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove support for file paths in plugin and stream constructors #2744

Open
edgarrmondragon opened this issue Nov 7, 2024 · 0 comments

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Nov 7, 2024

These add complexity for very little gain. Let's remove them in a future version.

elif isinstance(config, (str, PurePath)):
config_dict = read_json_file(config)

if isinstance(schema, (PathLike, str)):
if not Path(schema).is_file():
msg = f"Could not find schema file '{self.schema_filepath}'."
raise FileNotFoundError(msg)
self._schema_filepath = Path(schema)

sdk/singer_sdk/tap_base.py

Lines 103 to 104 in 62c03bb

elif catalog is not None:
self._input_catalog = Catalog.from_dict(read_json_file(catalog))

sdk/singer_sdk/tap_base.py

Lines 115 to 116 in 62c03bb

elif state:
state_dict = read_json_file(state)

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant