Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crash reason to handle_crash_group_down context #703

Closed
roznawsk opened this issue Jan 10, 2024 · 0 comments · Fixed by #720
Closed

Add crash reason to handle_crash_group_down context #703

roznawsk opened this issue Jan 10, 2024 · 0 comments · Fixed by #720
Assignees
@DominikWolek

Comments

@roznawsk
Copy link
Member

When handling group crash I would like to know the exception, which caused the crash.

17:24:30.329 [error] GenServer #PID<0.4391.0> terminating
** (RuntimeError) No supported payload types in SDP offer!
    (membrane_webrtc_plugin 0.17.0) lib/membrane_webrtc_plugin/track.ex:210: Membrane.WebRTC.Track.set_constraints/3

In the above example it would be great to have the (RuntimeError) No supported payload types in SDP offer!
in the context.
@mat-hek mat-hek added this to Smackore Jan 19, 2024
@mat-hek mat-hek moved this to Backlog in Smackore Jan 19, 2024
@DominikWolek DominikWolek self-assigned this Jan 22, 2024
@DominikWolek DominikWolek moved this from Backlog to In Progress in Smackore Jan 22, 2024
@DominikWolek DominikWolek moved this from In Progress to In Review in Smackore Jan 26, 2024
@DominikWolek DominikWolek linked a pull request Jan 26, 2024 that will close this issue
Add crash reason handle crash group #720
Merged
@github-project-automation github-project-automation bot moved this from In Review to Done in Smackore Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominikWolek DominikWolek

Labels
None yet
Projects
Smackore
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add crash reason handle crash group membraneframework/membrane_core
2 participants
@DominikWolek @roznawsk