Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper queue for multi-input elements #734

Closed
mat-hek opened this issue Jan 30, 2024 · 3 comments
Closed

Helper queue for multi-input elements #734

mat-hek opened this issue Jan 30, 2024 · 3 comments
Assignees

Comments

@mat-hek
Copy link
Member

mat-hek commented Jan 30, 2024

The idea is to have a queue that multi-input pads could use to consume buffers at proper speed. The goal is to make mixers and muxers code simpler, more declarative and thus less error-prone.

The queue should:

  • Consume buffers at equal speed from all pads, based on timestamps
  • Return pause_auto_demand and resume_auto_demand actions to avoid keeping too many buffers
  • Handle dynamically starting and ending streams

To verify the queue's functionality, we should use it in at least one muxer, for example in https://github.com/membraneframework/membrane_flv_plugin and mixer, for example in https://github.com/membraneframework/membrane_audio_mix_plugin

@mat-hek mat-hek added this to Smackore Jan 30, 2024
@mat-hek mat-hek moved this to Todo in Smackore Jan 30, 2024
@FelonEkonom FelonEkonom self-assigned this Feb 14, 2024
@FelonEkonom FelonEkonom moved this from Todo to In Progress in Smackore Feb 14, 2024
@FelonEkonom FelonEkonom moved this from In Progress to In Review in Smackore Mar 1, 2024
@FelonEkonom
Copy link
Member

FelonEkonom commented Mar 25, 2024

Done:

  • basic functionalities (push/pop)
  • waiting on pad
  • specify average chunk size, expresesed in time duration
  • specify pause demand boundary in time duration
  • flushing queue
  • specify timestamps offsets explicitly / allow different synchronization strategies

Issues:

  • lack of callback context

TODO:

  • write benchmarks and optimize the queue
  • live queue

Live queue concepts:

  • need of having master stream or some other way of telling the live queue what is the current live time
  • live queue should return buffers according to the clock
  • outdated buffers should be distincted from actual buffers

@FelonEkonom FelonEkonom moved this from In Review to In Progress in Smackore Apr 16, 2024
@FelonEkonom FelonEkonom moved this from In Progress to In Review in Smackore Apr 18, 2024
@FelonEkonom FelonEkonom moved this from In Review to In Progress in Smackore Apr 18, 2024
@varsill varsill moved this from In Progress to Done in Smackore Apr 24, 2024
@varsill varsill moved this from Done to In Progress in Smackore Apr 24, 2024
@darthez darthez moved this from In Progress to Todo in Smackore May 8, 2024
@darthez
Copy link

darthez commented Jun 5, 2024

Let's close this one and move the idea of live queue to discussions, @FelonEkonom

@FelonEkonom
Copy link
Member

Related discussion: https://github.com/orgs/membraneframework/discussions/818

@github-project-automation github-project-automation bot moved this from Todo to Done in Smackore Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants