Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom request AdditionaInstrumentationDetail #233

Open
idg10 opened this issue Jul 15, 2021 · 0 comments
Open

Enable custom request AdditionaInstrumentationDetail #233

idg10 opened this issue Jul 15, 2021 · 0 comments

Comments

@idg10
Copy link
Contributor

idg10 commented Jul 15, 2021

Menes calls IOperationsInstrumentation.StartOperation when invoking a service operation to ensure that applications that want telemetry will get clear information about when an operation starts and finishes, and that all other diagnostic telemetry produced while the operation runs is correlated with that operation.

Menes also passes an AdditionalInstrumentationDetail to StartOperation containing a single property, Menes.OperationId. This ensures that the operation is tagged with the operation ID. And if applications are using the Application Insights provide from Corvus.Monitoring, this property also flows to all correlated telemetry. This enables us to filter by operation ID, and see all telemetry corresponding to any particular OpenAPI operation.

Currently, there is no way for applications to add additional items to this per-operation detail. We have encountered scenarios in which applications want to add in extra, application-specific contextual information. Currently this is cumbersome because it needs to be added manually each time telemetry is generated. But if applications had a way to augment the detail passed to StartOperation, this manual effort could be avoided.

So we should consider adding something that enables applications to extend this information. E.g., an IOperationInstrumentationDetailBuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant