Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of IConfigurationRoot #27

Open
jamesbroome opened this issue Jan 14, 2020 · 0 comments
Open

Review use of IConfigurationRoot #27

jamesbroome opened this issue Jan 14, 2020 · 0 comments

Comments

@jamesbroome
Copy link

Proposal to change AddExternalServices so that I takes a strongly typed ExternalServicesOptions class instead of having to resolve IConfigurationRoot using a config section name.

New options class just needs BaseUrl as initial property for now, but can be expanded in the future if needed.

See: https://github.com/menes-dotnet/Menes/blob/5f653f387836a8e11ca015a0fc52cd1b2e36d56f/Solutions/Menes.Hosting/Microsoft/Extensions/DependencyInjection/OpenApiHostingServiceCollectionExtensions.cs

Only known use of this method is in Marain.Operations:

https://github.com/marain-dotnet/Marain.Operations/blob/3b86ab30feb0ae3c0ed429bb7f766fd219ee2f78/Solutions/Marain.Operations.OpenApi/Marain/Operations/OpenApi/OperationsStatusOpenApiService.cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant