Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples have wrong include #77

Open
vintprox opened this issue Mar 15, 2019 · 2 comments
Open

Examples have wrong include #77

vintprox opened this issue Mar 15, 2019 · 2 comments

Comments

@vintprox
Copy link

Many demos are pointing to absent scripts:

  • https://github.com/mozilla/popcorn-js/code/dist/popcorn-complete.min.js,
  • http://popcornjs.org/code/dist/popcorn-complete.js.

We need rewrite to https://raw.githubusercontent.com/menismu/popcorn-js/master/popcorn.js at least for pens in jsFiddle for proper demonstration of Popcorn.js features.
@vintprox
Copy link
Author

Side note: even https://raw.githubusercontent.com/menismu/popcorn-js/master/popcorn.js can't provide window.Popcorn, we have to import it first with some distribution min.js, which is absent rn.

@titaniumbones
Copy link

+1 for adding min.js to mastyer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titaniumbones @vintprox