Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: use .setAttribute('display', null) instead of display: inline or display: block #87

Open
titaniumbones opened this issue Nov 19, 2019 · 1 comment

Comments

@titaniumbones
Copy link

We hide plugin instances with display: none, but prevent users from styling instances directly when we use .style.display = 'block|inline'. Would be better to reset to null, which resets that parto f the tag's style attribute, but unlike unset or reset, doesn't override stylesheet declaration.

@titaniumbones
Copy link
Author

I've actualy been going through and using unset as the new value, which is perhaps cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant