Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Make Volume Control Service name editable #533

Open
Depicus opened this issue May 12, 2024 · 4 comments
Open

Feature Request - Make Volume Control Service name editable #533

Depicus opened this issue May 12, 2024 · 4 comments

Comments

@Depicus
Copy link

Depicus commented May 12, 2024

Is it possible to set the name of the Volume Control Service - I call it Telly Noise by setting it's name in HomeKit but every time I reboot Homebridge it reverts and I sound like a lunatic shouting at the TV to turn the Telly Noise off when it's now back to LG Volume Control.

Great plugin thank you.

@Depicus Depicus changed the title Feature Request Feature Request - Make Volume Control Service name editable May 12, 2024
@merdok
Copy link
Owner

merdok commented May 13, 2024

This is a known issue that after a reboot the names of the accessories revert back to the auto generated ones. I have it on my scope to provide a fix but since it will probably require some extensive code changes I did not find the time to do it yet... hopefully I can tackle it soon!

@ltdowney
Copy link

ltdowney commented Jun 1, 2024

I came here to request the volume service name be configurable as well and saw this, so +1 if you do get time at some point. 👍

I see that you set it as <accessory_name> + ‘ Volume’. The problem is that my accessory is named “Living Room TV”, but Siri gets confused when I ask her to adjust the “Living Room TV Volume” – probably because the AI hears “Living Room TV” and expects it to be an attribute on the TV itself – so I have to ask in a contorted way, like “adjust the Living Room level to 10%”. Fortunately I don’t have any dimmer-light accessories in my home, otherwise that wouldn’t work as she’d adjust all of them.

Regardless though, thanks for the great plugin, it’s enabled me to do a lot of cool automations that aren’t possible with LG’s own implementation!

@merdok
Copy link
Owner

merdok commented Jun 1, 2024

A very important note is that Siri officially cannot control the volume of any devices, so if there is the word "Volume" in your command then it might misinterpret it. You have to control the volume as you would control the light bulb or fan which is used to emulate it, hence saying "Set living room level to 20%" is the correct and only way to do that.

@ltdowney
Copy link

ltdowney commented Jun 27, 2024

Sorry for the month-late follow-up / ping, just noticed your reply in my notifications. Don’t mean to belabor the point, just a couple more thoughts and then I’ll leave you in peace to [de-]prioritize as you see fit. 😅

A very important note is that Siri officially cannot control the volume of any devices, so if there is the word "Volume" in your command then it might misinterpret it. You have to control the volume as you would control the light bulb or fan which is used to emulate it, hence saying "Set living room level to 20%" is the correct and only way to do that.

For sure, that’s the most natural term I could think of for now, and it does work. I think the strongest argument would probably be to work around collision with actual dimmer lights in the same room. Admittedly I don’t have that problem, but it’d probably be a showstopper for that feature to anyone who does.

In terms of what I might actually do with a configurable service name, I can imagine some that might be useful along the lines of “Living Room Speakers” or “Living Room Output” – Siri limitations permitting… Let’s hope Apple Intelligence can make her more capable, in any case! 😆🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants