Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/show toast options #46

Merged
merged 11 commits into from
Aug 6, 2020
Merged

Update/show toast options #46

merged 11 commits into from
Aug 6, 2020

Conversation

phoward38
Copy link
Collaborator

  • Updated .options argument for showToast to use defaults

    • Adding an option to the argument overwrites the default
    • Exception: timeOut & extendedTimeOut are 0 when keepVisible=TRUE
  • Note: Options are only applied to a toast once all other toasts are off the screen. Otherwise, the new toast has the same options applied as the toast on screen

R/showToast.R Outdated Show resolved Hide resolved
R/showToast.R Outdated Show resolved Hide resolved
Copy link
Owner

@merlinoa merlinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phoward38 please respond to my comments and lmk if you have questions

@phoward38
Copy link
Collaborator Author

@merlinoa Issues resolved

@phoward38
Copy link
Collaborator Author

@merlinoa Adding new toastr.js.map & toastr.min.js. Contains quick fix for the different positionClass argument bug. Taken from PR CodeSeven/toastr#635 that has yet to be merged.

@merlinoa merlinoa merged commit 55a13b3 into master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants