De-duplicate Ambient LED management code #5194
Labels
good first issue
Good for newcomers
help wanted
Extra attention is needed
low-priority
Possibly something we'll consider in the future but doesn't serve the core use-cases or problematic
We currently have 3 different places where we have the logic for modifying LED state of the various types of Ambient LEDs,
ExternalNotificationModule::SetExternalState
AmbientLightingThread::setLighting
AmbientLightingThread::setLightingOff
Instead, we should have a single place where this happens.
Use the notification system we have in the firmware for IPC, so that Ambient lighting offers a subscription service for LED changes and the External Notifications uses it (if available).
You can look at how it's done for notifying others about GPS position changes :-)
The text was updated successfully, but these errors were encountered: