Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a variety of type annotations for mypy #681

Merged
merged 9 commits into from
Oct 29, 2024

Fix some remaining mypy complaints

384063d
Select commit
Loading
Failed to load commit list.
Merged

Add a variety of type annotations for mypy #681

Fix some remaining mypy complaints
384063d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 29, 2024 in 0s

60.35% (-0.03%) compared to 0deb1d7, passed because coverage increased by 0.95% when compared to adjusted base (59.40%)

View this Pull Request on Codecov

60.35% (-0.03%) compared to 0deb1d7, passed because coverage increased by 0.95% when compared to adjusted base (59.40%)

Details

Codecov Report

Attention: Patch coverage is 85.10638% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (0deb1d7) to head (384063d).

Files with missing lines Patch % Lines
meshtastic/ble_interface.py 43.75% 9 Missing ⚠️
meshtastic/stream_interface.py 70.00% 6 Missing ⚠️
meshtastic/util.py 94.00% 3 Missing ⚠️
meshtastic/__main__.py 90.00% 2 Missing ⚠️
meshtastic/tcp_interface.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   60.37%   60.35%   -0.03%     
==========================================
  Files          24       24              
  Lines        3793     3811      +18     
==========================================
+ Hits         2290     2300      +10     
- Misses       1503     1511       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.