Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai-navigator): Add missing defaults directory and manifests #1652

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Oct 4, 2023

What problem does this PR solve?:
Enabling ai-navigator was causing kustomization errors due to missing defaults/ dir and manifests.

kommander                     ai-navigator-app-0.1.0-defaults             46m   False     kustomization path not found: stat /tmp/kustomization-2697881657/services/ai-navigator-app/0.1.0/defaults: no such file or directory

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-99374

Special notes for your reviewer:

Tested this fix on the daily and saw the kustomization resolve successfully

k get kustomizations -n kommander -w | grep navigator
ai-navigator-app                            93m   True      Applied revision: main@sha1:06df51eb92b7d8c8f6973385dd5c64f09efd893d
ai-navigator-app-0.1.0-defaults             93m   False     kustomization path not found: stat /tmp/kustomization-3714011164/services/ai-navigator-app/0.1.0/defaults: no such file or directory

ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   True      Applied revision: main@sha1:7c141d7635cd25f20ad187b49f3ce9bae618b867
ai-navigator-app-0.1.0-defaults             94m   True      Applied revision: main@sha1:7c141d7635cd25f20ad187b49f3ce9bae618b867
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   Unknown   Reconciliation in progress
ai-navigator-app                            94m   True      Applied revision: main@sha1:7c141d7635cd25f20ad187b49f3ce9bae618b867
ai-navigator-app                            94m   True      Applied revision: main@sha1:7c141d7635cd25f20ad187b49f3ce9bae618b867
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   Unknown   Reconciliation in progress
ai-navigator-app-0.1.0-defaults             94m   True      Applied revision: main@sha1:7c141d7635cd25f20ad187b49f3ce9bae618b867

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Oct 4, 2023
@gracedo gracedo self-assigned this Oct 4, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2023
@gracedo gracedo marked this pull request as ready for review October 4, 2023 22:41
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo added needs-backport Needs to be backported to a release branch auto-backport backport-to-release-2.6 labels Oct 4, 2023
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
It's the default settings we're talking about here

@cwyl02 cwyl02 merged commit 80bfcbe into release-2.6 Oct 4, 2023
33 checks passed
@cwyl02 cwyl02 deleted the gracedo/chatbot_defaults_D2IQ-99374 branch October 4, 2023 23:08
@gracedo gracedo restored the gracedo/chatbot_defaults_D2IQ-99374 branch October 5, 2023 16:01
@gracedo
Copy link
Contributor Author

gracedo commented Oct 5, 2023

@d2iq-mergebot backport main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.6 needs-backport Needs to be backported to a release branch ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants